Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add benchmarks for creating web responses #9940

Merged
merged 3 commits into from
Nov 17, 2024
Merged

Add benchmarks for creating web responses #9940

merged 3 commits into from
Nov 17, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 17, 2024 •
edited
Loading

Focused benchmark to measure changes in web.*Response creation time for #9895

related issue #2779

@bdraco bdraco added bot:chronographer:skip This PR does not need to include a change note backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot labels Nov 17, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 17, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #9940 will not alter performance

Comparing web_response_benchmarks (2b7baca) with master (0c31249)

Summary

✅ 37 untouched benchmarks

🆕 5 new benchmarks

Benchmarks breakdown

Benchmark master web_response_benchmarks Change
🆕 test_simple_web_response N/A 804.9 µs N/A
🆕 test_simple_web_stream_response N/A 557.8 µs N/A
🆕 test_web_response_with_bytes_body N/A 901.5 µs N/A
🆕 test_web_response_with_headers N/A 1.4 ms N/A
🆕 test_web_response_with_text_body N/A 1 ms N/A

@codecov Codecov
Copy link

codecov bot commented Nov 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.72%. Comparing base (0c31249) to head (2b7baca).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #9940   +/-   ##
=======================================
  Coverage   98.72%   98.72%           
=======================================
  Files         120      121    +1     
  Lines       36588    36621   +33     
  Branches     4366     4376   +10     
=======================================
+ Hits        36120    36153   +33     
  Misses        315      315           
  Partials      153      153
Flag Coverage Δ
CI-GHA 98.61% <100.00%> (+<0.01%) ⬆️
OS-Linux 98.30% <100.00%> (+<0.01%) ⬆️
OS-Windows 96.12% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.39% <100.00%> (-0.01%) ⬇️
Py-3.10.11 97.23% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 97.84% <100.00%> (+0.05%) ⬆️
Py-3.11.10 97.83% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.28% <100.00%> (+<0.01%) ⬆️
Py-3.12.7 98.36% <100.00%> (-0.01%) ⬇️
Py-3.13.0 98.35% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 97.16% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 97.75% <100.00%> (+0.04%) ⬆️
Py-pypy7.3.16 97.31% <100.00%> (+<0.01%) ⬆️
VM-macos 97.39% <100.00%> (-0.01%) ⬇️
VM-ubuntu 98.30% <100.00%> (+<0.01%) ⬆️
VM-windows 96.12% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco enabled auto-merge (squash) November 17, 2024 18:53
@bdraco bdraco merged commit 9ca1a58 into master Nov 17, 2024
38 of 39 checks passed
@bdraco bdraco deleted the web_response_benchmarks branch November 17, 2024 18:55
@patchback Patchback
Copy link
Contributor

patchback bot commented Nov 17, 2024 •
edited
Loading

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/9ca1a58114fd2021e382ccdc96085aa095948009/pr-9940

Backported as #9941

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 17, 2024
@bdraco @patchback
Add benchmarks for creating web responses (#9940)
a10d984 
(cherry picked from commit 9ca1a58)
@patchback patchback bot mentioned this pull request Nov 17, 2024
Merged
@patchback Patchback
Copy link
Contributor

patchback bot commented Nov 17, 2024 •
edited
Loading

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/9ca1a58114fd2021e382ccdc96085aa095948009/pr-9940

Backported as #9942

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 17, 2024
@bdraco @patchback
Add benchmarks for creating web responses (#9940)
1cdeac0 
(cherry picked from commit 9ca1a58)
@patchback patchback bot mentioned this pull request Nov 17, 2024
Merged
@patchback Patchback
Copy link
Contributor

patchback bot commented Nov 17, 2024 •
edited
Loading

Backport to 3.12: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.12/9ca1a58114fd2021e382ccdc96085aa095948009/pr-9940

Backported as #9943

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 17, 2024
@bdraco @patchback
Add benchmarks for creating web responses (#9940)
948eefc 
(cherry picked from commit 9ca1a58)
@patchback patchback bot mentioned this pull request Nov 17, 2024
Merged
bdraco added a commit that referenced this pull request Nov 17, 2024
@patchback @bdraco
[PR #9940/9ca1a581 backport][3.10] Add benchmarks for creating web re…
dddb925 
…sponses (#9941)

Co-authored-by: J. Nick Koston <[email protected]>
bdraco added a commit that referenced this pull request Nov 17, 2024
@patchback @bdraco
[PR #9940/9ca1a581 backport][3.11] Add benchmarks for creating web re…
6cf4497 
…sponses (#9942)

Co-authored-by: J. Nick Koston <[email protected]>
bdraco added a commit that referenced this pull request Nov 17, 2024
@patchback @bdraco
[PR #9940/9ca1a581 backport][3.12] Add benchmarks for creating web re…
d7d4a3a 
…sponses (#9943)

Co-authored-by: J. Nick Koston <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bdraco